diff --git a/src/generate/album_dir.rs b/src/generate/album_dir.rs index 461debb..a77eb25 100644 --- a/src/generate/album_dir.rs +++ b/src/generate/album_dir.rs @@ -19,7 +19,7 @@ pub struct AlbumDir { impl AlbumDir { /// Returns an iterator over all images in the album and subalbums - pub fn iter_all_images(&self) -> AlbumImageIter { + pub fn iter_all_images(&self) -> AlbumImageIter<'_> { AlbumImageIter::new(self) } @@ -79,20 +79,20 @@ impl AlbumDir { } } } - } else if entry_path.is_dir() { - if let Some(dirname) = entry_path.file_name().and_then(|n| n.to_str()) { - if dirname.starts_with("_") { - // Likely a templates or static dir - continue; - } else if dirname == "site" { - // Is a generated site dir, don't descend into it - continue; - } else if dirname == "slides" { - continue; - } - - children.push(AlbumDir::from_path(&entry_path, root)?); + } else if entry_path.is_dir() + && let Some(dirname) = entry_path.file_name().and_then(|n| n.to_str()) + { + if dirname.starts_with("_") { + // Likely a templates or static dir + continue; + } else if dirname == "site" { + // Is a generated site dir, don't descend into it + continue; + } else if dirname == "slides" { + continue; } + + children.push(AlbumDir::from_path(&entry_path, root)?); } } diff --git a/src/generate/image.rs b/src/generate/image.rs index 1053d3f..91dc1c8 100644 --- a/src/generate/image.rs +++ b/src/generate/image.rs @@ -55,17 +55,15 @@ impl Image { /// return "blah.thumb" fn slide_filename(path: &Path, ext: &str, keep_ext: bool) -> anyhow::Result { let mut new_ext: OsString = ext.into(); - if keep_ext { - if let Some(e) = path.extension() { - new_ext = OsString::from( - ext.to_string() - + "." - + e.to_str().ok_or(anyhow!( - "Image {} extension is not valid UTF-8", - path.display() - ))?, - ) - } + if keep_ext && let Some(e) = path.extension() { + new_ext = OsString::from( + ext.to_string() + + "." + + e.to_str().ok_or(anyhow!( + "Image {} extension is not valid UTF-8", + path.display() + ))?, + ) } let new_path = path.with_extension(new_ext); diff --git a/src/reorganize.rs b/src/reorganize.rs index f96c089..0b2a007 100644 --- a/src/reorganize.rs +++ b/src/reorganize.rs @@ -1,7 +1,7 @@ -use anyhow::{anyhow, Context}; +use anyhow::{Context, anyhow}; use image::ImageReader; use std::ffi::OsStr; -use std::fs::{rename, File}; +use std::fs::{File, rename}; use std::io::BufReader; use std::path::{Path, PathBuf}; use std::str::from_utf8;